DocDiff: Cache remote content #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
Nov 20, 2024
|
Realized we were "double triggering" the addon when the passed the GET arg, and now moved the state of enabled/disabled into the Addon. |
agjohnson
reviewed
Nov 21, 2024
agjohnson
reviewed
Nov 27, 2024
|
This should be working now 🎉 |
agjohnson
approved these changes
Dec 2, 2024
humitos
reviewed
Dec 3, 2024
humitos
approved these changes
Dec 4, 2024
Comment on lines
+124
to
+125
| // This code isn't used until we show a UI, | ||
| // and even then we'll want to trigger events to match state? |
There was a problem hiding this comment.
Ah, this code was used in the render() method from above originally when I tried using a slider. We never deployed that, so we can probably remove that and this chunk as well.
This was referenced Dec 5, 2024
humitos
added a commit
that referenced
this pull request
Dec 9, 2024
HotKeys has to be initialized before DocDiff because when `?readthedocs-diff=true` DocDiff triggers an event that HotKeys has to listen to to update its internal state. * Related #645 * Related #441
ericholscher
pushed a commit
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103